Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.

Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
Committed: https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
Cr-Commit-Position: refs/heads/master@{#362258}

[scottmg, 2015-11-27 17:01:59]

Description was changed from

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org,cpu@chromium.org
BUG=447073, 546288, 456193
==========

to

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org,cpu@chromium.org
BUG=447073, 546288, 456193
==========

[scottmg, 2015-11-27 22:02:43]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-11-27 22:07:02]

Description was changed from

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org,cpu@chromium.org
BUG=447073, 546288, 456193
==========

to

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org,cpu@chromium.org
BUG=447073, 546288, 456193
==========

[scottmg, 2015-11-27 22:54:15]

Patchset #3 (id:60001) has been deleted

[scottmg, 2015-11-30 18:17:13]

To be updated with correct DEPS roll after Crashpad-side fix lands.

[Mark Mentovai, 2015-11-30 18:42:18]

LGTM

[scottmg, 2015-11-30 21:51:56]

Description was changed from

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org,cpu@chromium.org
BUG=447073, 546288, 456193
==========

to

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
==========

[scottmg, 2015-11-30 22:08:50]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-11-30 22:08:51]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1479283002/#ps100001
(title: "with crashpad 1f3ced1846f3956e678c562c90e0d6c970543617")

[commit-bot: I haz the power, 2015-11-30 22:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1479283002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1479283002/100001

[commit-bot: I haz the power, 2015-11-30 23:13:53]

Description was changed from

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
==========

to

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
==========

[commit-bot: I haz the power, 2015-11-30 23:13:54]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-11-30 23:14:53]

Description was changed from

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.


Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
==========

to

==========
Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.

- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.

Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.

On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.

Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8

See also http://crbug.com/427611 .

R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193

Committed: https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
Cr-Commit-Position: refs/heads/master@{#362258}
==========

[commit-bot: I haz the power, 2015-11-30 23:14:54]

Patchset 4 (id:??) landed as
https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
Cr-Commit-Position: refs/heads/master@{#362258}

[Mark Mentovai, 2015-12-01 00:05:38]

Awesome! I hope it sticks this time.

[Will Harris, 2015-12-01 00:39:16]

yay 🎈 🎈

[gab, 2015-12-01 15:26:31]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/1490613004/ by gab@chromium.org.

The reason for reverting is: Breaks Win x64 GN compile :
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN?numbuilds=200

(sad that this bot doesn't have a CQ counterpart...).