Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1479233002: Deprecate the %IsConstructCall intrinsic completely. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_js-use-new-target-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate the %IsConstructCall intrinsic completely. R=bmeurer@chromium.org Committed: https://crrev.com/82e6bed4dbe5fa0173d0751148544fc3fdc3b898 Cr-Commit-Position: refs/heads/master@{#32470}

Patch Set 1 #

Patch Set 2 : Ported to all architectures. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -709 lines) Patch
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 2 chunks +0 lines, -16 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 1 2 chunks +0 lines, -15 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 1 2 chunks +0 lines, -14 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 17 chunks +17 lines, -17 lines 0 comments Download
M test/mjsunit/regress/regress-1229.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
5 years ago (2015-11-27 16:25:52 UTC) #3
Benedikt Meurer
Remove all the lithium code! I like it. LGTM
5 years ago (2015-11-27 17:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479233002/60001
5 years ago (2015-12-01 14:48:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-01 15:58:23 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-01 15:59:04 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/82e6bed4dbe5fa0173d0751148544fc3fdc3b898
Cr-Commit-Position: refs/heads/master@{#32470}

Powered by Google App Engine
This is Rietveld 408576698