Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: Source/devtools/front_end/CPUProfileView.js

Issue 147923011: Remove unnecessary _profileTypesByIdMap map (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comments addressed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/profiler/profiler-test.js ('k') | Source/devtools/front_end/HeapSnapshotView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/CPUProfileView.js
diff --git a/Source/devtools/front_end/CPUProfileView.js b/Source/devtools/front_end/CPUProfileView.js
index abe84c64bb8864a435971095703e288bde1a3136..d0c12a28b8c7937ffe8abe2988fce9de92e75baf 100644
--- a/Source/devtools/front_end/CPUProfileView.js
+++ b/Source/devtools/front_end/CPUProfileView.js
@@ -734,7 +734,9 @@ WebInspector.CPUProfileType.prototype = {
a.addEventListener("click", onClick.bind(this), true);
function onClick(event)
{
- WebInspector.showPanel("profiles").showProfile(WebInspector.CPUProfileType.TypeId, id);
+ var profile = WebInspector.ProfileTypeRegistry.instance.cpuProfileType.getProfile(id);
+ if (profile)
+ WebInspector.showPanel("profiles").showProfile(profile);
}
messageElement.createTextChild("' finished.");
@@ -809,7 +811,7 @@ WebInspector.CPUProfileType.prototype = {
this._profileBeingRecorded.sidebarElement.mainTitle = title;
var recordedProfile = this._profileBeingRecorded;
this._profileBeingRecorded = null;
- WebInspector.panels.profiles._showProfile(recordedProfile);
+ WebInspector.panels.profiles.showProfile(recordedProfile);
}
ProfilerAgent.stop(didStopProfiling.bind(this));
},
« no previous file with comments | « LayoutTests/inspector/profiler/profiler-test.js ('k') | Source/devtools/front_end/HeapSnapshotView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698