Source/devtools/front_end/CPUProfileView.js - Issue 147923011: Remove unnecessary _profileTypesByIdMap map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/CPUProfileView.js

Issue 147923011: Remove unnecessary _profileTypesByIdMap map (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/CPUProfileView.js

diff --git a/Source/devtools/front_end/CPUProfileView.js b/Source/devtools/front_end/CPUProfileView.js

index abe84c64bb8864a435971095703e288bde1a3136..1607d5b48f923dd00d8c8394aa3ea7ebc3640681 100644

--- a/Source/devtools/front_end/CPUProfileView.js

+++ b/Source/devtools/front_end/CPUProfileView.js

@@ -734,7 +734,9 @@ WebInspector.CPUProfileType.prototype = {

a.addEventListener("click", onClick.bind(this), true);

function onClick(event)

{

- WebInspector.showPanel("profiles").showProfile(WebInspector.CPUProfileType.TypeId, id);

+ var profile = WebInspector.ProfileTypeRegistry.instance.cpuProfileType.getProfile(id);

+ if (profile)

+ WebInspector.showPanel("profiles")._showProfile(profile);

loislo 2014/01/29 09:08:55 please make it public

yurys 2014/01/29 09:15:13 Done.

}

messageElement.createTextChild("' finished.");