Issue 147923011: Remove unnecessary _profileTypesByIdMap map

Issue 147923011: Remove unnecessary _profileTypesByIdMap map (Closed)

Created:
6 years, 10 months ago by yurys

Modified:
6 years, 10 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unnecessary _profileTypesByIdMap map BUG=None R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166013

Patch Set 1 #

Total comments: 4

Patch Set 2 : Renamed _showProfile to showProfile #

Patch Set 3 : Comments addressed #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -87 lines)			Patch
M	LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/profiler/cpu-profiler-save-load.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-loader.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-test.js	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/profiler/profiler-test.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/CPUProfileView.js	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotView.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ProfileLauncherView.js	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/ProfilesPanel.js	View	1	14 chunks	+17 lines, -65 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

loislo

lgtm with nits https://codereview.chromium.org/147923011/diff/1/Source/devtools/front_end/CPUProfileView.js File Source/devtools/front_end/CPUProfileView.js (right): https://codereview.chromium.org/147923011/diff/1/Source/devtools/front_end/CPUProfileView.js#newcode739 Source/devtools/front_end/CPUProfileView.js:739: WebInspector.showPanel("profiles")._showProfile(profile); please make it public https://codereview.chromium.org/147923011/diff/1/Source/devtools/front_end/ProfileLauncherView.js ...

6 years, 10 months ago (2014-01-29 09:08:55 UTC) #2

yurys

https://codereview.chromium.org/147923011/diff/1/Source/devtools/front_end/CPUProfileView.js File Source/devtools/front_end/CPUProfileView.js (right): https://codereview.chromium.org/147923011/diff/1/Source/devtools/front_end/CPUProfileView.js#newcode739 Source/devtools/front_end/CPUProfileView.js:739: WebInspector.showPanel("profiles")._showProfile(profile); On 2014/01/29 09:08:55, loislo wrote: > please make ...

6 years, 10 months ago (2014-01-29 09:15:12 UTC) #3

yurys

6 years, 10 months ago (2014-01-29 09:43:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r166013 (presubmit successful).

Expand Messages | Collapse Messages