chrome/browser/extensions/api/storage/settings_apitest.cc - Issue 147923005: Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_apitest.cc

Issue 147923005: Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re^3base Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/managed_value_store_cache.cc ('k') | chrome/browser/extensions/api/storage/settings_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_apitest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_apitest.cc b/chrome/browser/extensions/api/storage/settings_apitest.cc

index 2cf74da8c216c46f1f29f987a086bd0f6fae8884..28095434511bdc03b82fd8895d15820f6f39b520 100644

--- a/chrome/browser/extensions/api/storage/settings_apitest.cc

+++ b/chrome/browser/extensions/api/storage/settings_apitest.cc

@@ -12,12 +12,12 @@

#include "chrome/browser/extensions/api/storage/settings_sync_util.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_service.h"

-#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/extensions/extension_system_factory.h"

#include "chrome/browser/extensions/extension_test_message_listener.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "extensions/browser/extension_system.h"

#include "extensions/common/value_builder.h"

#include "sync/api/sync_change.h"

#include "sync/api/sync_change_processor.h"

@@ -458,8 +458,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionSettingsApiTest, IsStorageEnabled) {

IN_PROC_BROWSER_TEST_F(ExtensionSettingsApiTest, ExtensionsSchemas) {

// Verifies that the Schemas for the extensions domain are created on startup.

Profile* profile = browser()->profile();

- ExtensionSystem* extension_system =

- ExtensionSystemFactory::GetForProfile(profile);

+ ExtensionSystem* extension_system = ExtensionSystem::Get(profile);

if (!extension_system->ready().is_signaled()) {

// Wait until the extension system is ready.

base::RunLoop run_loop;