Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1479143002: [proxies] [[HasProperty]]: fix trap call. (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] [[HasProperty]]: fix trap call. BUG=v8:1543 LOG=n Committed: https://crrev.com/2ba464e11cb4bddc82e554ea7cd0fd28bc2936d0 Cr-Commit-Position: refs/heads/master@{#32391}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -26 lines) Patch
M src/contexts.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/js/proxy.js View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 chunks +63 lines, -15 lines 0 comments Download
M test/mjsunit/harmony/proxies-enumerate.js View 2 chunks +6 lines, -2 lines 0 comments Download
A test/mjsunit/harmony/proxies-has.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jakob Kummerow
Georg: PTAL. Camillo: FYI.
5 years ago (2015-11-27 09:31:05 UTC) #2
neis
lgtm https://codereview.chromium.org/1479143002/diff/1/src/js/proxy.js File src/js/proxy.js (right): https://codereview.chromium.org/1479143002/diff/1/src/js/proxy.js#newcode135 src/js/proxy.js:135: } I think this one should go as ...
5 years ago (2015-11-27 14:30:24 UTC) #3
Jakob Kummerow
Thanks for the review, landing. https://codereview.chromium.org/1479143002/diff/1/src/js/proxy.js File src/js/proxy.js (right): https://codereview.chromium.org/1479143002/diff/1/src/js/proxy.js#newcode135 src/js/proxy.js:135: } On 2015/11/27 14:30:24, ...
5 years ago (2015-11-30 08:49:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479143002/20001
5 years ago (2015-11-30 09:01:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 09:20:28 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 09:21:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ba464e11cb4bddc82e554ea7cd0fd28bc2936d0
Cr-Commit-Position: refs/heads/master@{#32391}

Powered by Google App Engine
This is Rietveld 408576698