base/trace_event/memory_dump_manager_unittest.cc - Issue 1479003003: Revert of Fix regression in memory-infra bots due to change in dump order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 1479003003: Revert of Fix regression in memory-infra bots due to change in dump order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/memory_dump_manager_unittest.cc

diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc

index 464ca2da48c5e8e6a224668b92e7487946b0cd7e..d32bdaaa93c22f6fff3fef0e0e10cbfafb72d015 100644

--- a/base/trace_event/memory_dump_manager_unittest.cc

+++ b/base/trace_event/memory_dump_manager_unittest.cc

@@ -717,8 +717,7 @@

// Tests against race conditions that might arise when disabling tracing in the

// middle of a global memory dump.

-// TODO(ssid): Enable this test once crbug.com/555584 is fixed.

-TEST_F(MemoryDumpManagerTest, DISABLED_DisableTracingWhileDumping) {

+TEST_F(MemoryDumpManagerTest, DisableTracingWhileDumping) {

base::WaitableEvent tracing_disabled_event(false, false);

InitializeMemoryDumpManager(false /* is_coordinator */);

« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | no next file » | no next file with comments »