Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1479003003:
Revert of Fix regression in memory-infra bots due to change in dump order (Closed)
|
Created:
5 years ago by ssid Modified:
5 years ago CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, bashi Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ )
Reason for revert:
Along with this CL, the memory-infra build was broken
(fixed in https://codereview.chromium.org/1474543003/). But, this
cause much noise in the metrics and did not give a clear idea if the
change fixed the original regression. So, I will revert this again
and re-land it to check if that actually makes a difference.
Original issue's description:
> Fix regression in memory-infra bots due to change in dump order
>
> crrev.com/1427963002 introduced a new memory-infra thread which runs
> after all dump providers are finished. This measures the process total
> memory usages. This was previously running at the start of a memory
> dump. This means that the memory used while taking memory dump of other
> providers will be included in the totals now and this metric has
> regressed. This CL is a temporary change that reverts this behaviour so
> that the perf bots are happy. Better fix for the problem will follow up
> soon.
>
> BUG=555584
>
> Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8
> Cr-Commit-Position: refs/heads/master@{#361126}
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=555584
Committed: https://crrev.com/6bf41bd974a754ee4e80f77099f4e0bf0bc793fa
Cr-Commit-Position: refs/heads/master@{#361899}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Created Revert of Fix regression in memory-infra bots due to change in dump order
Description was changed from ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} TBR=dsinclair@chromium.org,primiano@chromium.org,picksi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555584 ========== to ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} TBR=dsinclair@chromium.org,primiano@chromium.org,picksi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555584 ==========
Description was changed from ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} TBR=dsinclair@chromium.org,primiano@chromium.org,picksi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555584 ========== to ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} NOPRESUBMIT=true NOTREECHECKS=true BUG=555584 ==========
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479003003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssid@chromium.org
The CQ bit was unchecked by ssid@chromium.org
lgtm
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479003003/1
Message was sent while issue was closed.
Description was changed from ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} NOPRESUBMIT=true NOTREECHECKS=true BUG=555584 ========== to ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} NOPRESUBMIT=true NOTREECHECKS=true BUG=555584 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} NOPRESUBMIT=true NOTREECHECKS=true BUG=555584 ========== to ========== Revert of Fix regression in memory-infra bots due to change in dump order (patchset #1 id:1 of https://codereview.chromium.org/1466293002/ ) Reason for revert: Along with this CL, the memory-infra build was broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause much noise in the metrics and did not give a clear idea if the change fixed the original regression. So, I will revert this again and re-land it to check if that actually makes a difference. Original issue's description: > Fix regression in memory-infra bots due to change in dump order > > crrev.com/1427963002 introduced a new memory-infra thread which runs > after all dump providers are finished. This measures the process total > memory usages. This was previously running at the start of a memory > dump. This means that the memory used while taking memory dump of other > providers will be included in the totals now and this metric has > regressed. This CL is a temporary change that reverts this behaviour so > that the perf bots are happy. Better fix for the problem will follow up > soon. > > BUG=555584 > > Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 > Cr-Commit-Position: refs/heads/master@{#361126} NOPRESUBMIT=true NOTREECHECKS=true BUG=555584 Committed: https://crrev.com/6bf41bd974a754ee4e80f77099f4e0bf0bc793fa Cr-Commit-Position: refs/heads/master@{#361899} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6bf41bd974a754ee4e80f77099f4e0bf0bc793fa Cr-Commit-Position: refs/heads/master@{#361899}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1485813002/ by ssid@chromium.org. The reason for reverting is: We have seen that the regression is fixed for renderer process, but not browser process. The browser process regression is due to other CLs. https://goo.gl/2I5xkG. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
