ChromeOS: Use file extensions in Files app to decide which apps to use.

chrome/browser/extensions/api/file_handlers/app_file_handler_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_FILE_HANDLERS_APP_FILE_HANDLER_UTIL_H_
 #define CHROME_BROWSER_EXTENSIONS_API_FILE_HANDLERS_APP_FILE_HANDLER_UTIL_H_
 
 #include <set>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "chrome/common/extensions/api/file_handlers/file_handlers_parser.h"
 #include "chrome/common/extensions/extension.h"
 
 class Profile;
 
 namespace extensions {
 
 // TODO(benwells): move this to platform_apps namespace.
 namespace app_file_handler_util {
 
+// A set of pairs of path and its corresponding MIME type.
+typedef std::set<std::pair<base::FilePath, std::string> > PathAndMimeTypeSet;
+
 // Returns the file handler with the specified |handler_id|, or NULL if there
 // is no such handler.
 const FileHandlerInfo* FileHandlerForId(const Extension& app,
                                         const std::string& handler_id);
 
 // Returns the first file handler that can handle the given MIME type or
 // filename, or NULL if is no such handler.
 const FileHandlerInfo* FirstFileHandlerForFile(
     const Extension& app,
     const std::string& mime_type,
     const base::FilePath& path);
 
 std::vector<const FileHandlerInfo*>
-FindFileHandlersForMimeTypes(const Extension& extension,
-                             const std::set<std::string>& mime_types);
+FindFileHandlers(const Extension& extension,

[benwells, 2013/05/07 08:05:17]

Nit: please rename to just FileHandlersForFiles and add a comment explaining the
logic (i.e. that file handlers matching all files are found).

Also explain that files must be populated with paths but that the mime type is
optional.

[Sam McNally, 2013/05/07 08:25:54]

Done.

+                 const PathAndMimeTypeSet& files);
 
 bool FileHandlerCanHandleFile(
     const FileHandlerInfo& handler,
     const std::string& mime_type,
     const base::FilePath& path);
-bool FileHandlerCanHandleFileWithMimeType(
-    const FileHandlerInfo& handler,
-    const std::string& mime_type);
 
 // Represents a file entry that a user has given an extension permission to
 // access. Intended to be persisted to disk (in the Preferences file), so should
 // remain serializable.
 struct SavedFileEntry {
   SavedFileEntry(const std::string& id,
                  const base::FilePath& path,
                  bool writable)
       : id(id),
         path(path),
@@ skipping 18 matching lines @@
     const std::string& extension_id,
     int renderer_id,
     const base::FilePath& path,
     bool writable);
 
 }  // namespace app_file_handler_util
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_FILE_HANDLERS_APP_FILE_HANDLER_UTIL_H_