Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1478953004: Removed unnecessary SubtreeStyleChange for incrementalAttr. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unnecessary SubtreeStyleChange for incrementalAttr. Changing the incremental attribute on input type=search does not affect style unless there are attribute selectors for it which will be handled other places. R=tkent@chromium.org BUG=557440 Committed: https://crrev.com/5a819def379091a781a771dd60c1e53d1a0a9818 Cr-Commit-Position: refs/heads/master@{#362076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/input-search-incremental.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/input-search-incremental-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
5 years ago (2015-11-27 13:08:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478953004/1
5 years ago (2015-11-27 13:09:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 14:28:30 UTC) #5
tkent
lgtm. Though I'd like to remove the non-standard |incremental| attribute, reducing SubtreeStyleChange is nice.
5 years ago (2015-11-29 23:43:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478953004/1
5 years ago (2015-11-30 00:14:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 01:21:26 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 01:22:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a819def379091a781a771dd60c1e53d1a0a9818
Cr-Commit-Position: refs/heads/master@{#362076}

Powered by Google App Engine
This is Rietveld 408576698