Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1478953002: [turbofan] Optimize truncated safe integer multiplications. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, fedor.indutny
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize truncated safe integer multiplications. For a * b with only truncated word32 uses (or result known to be in signed32 range), we can use Int32Mul if we know for sure that the intermediate result is inside the safe integer range, and a and b are in signed32 range. Drive-by-fix: Also use TypeCache in SimplifiedLowering. R=jarin@chromium.org Committed: https://crrev.com/b5d50296ede3cae2bc2a7b6b8602ad1c92565977 Cr-Commit-Position: refs/heads/master@{#32330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M src/compiler/simplified-lowering.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 7 chunks +24 lines, -19 lines 0 comments Download
M src/type-cache.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
5 years ago (2015-11-26 10:26:59 UTC) #1
Benedikt Meurer
Jaro: PTAL Fedor: FYI
5 years ago (2015-11-26 10:27:25 UTC) #2
Jarin
lgtm. Nice!
5 years ago (2015-11-26 10:43:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478953002/1
5 years ago (2015-11-26 10:51:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 11:01:05 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-26 11:01:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5d50296ede3cae2bc2a7b6b8602ad1c92565977
Cr-Commit-Position: refs/heads/master@{#32330}

Powered by Google App Engine
This is Rietveld 408576698