src/heap/gc-tracer.cc - Issue 1478943003: Use WeakCells in the optimized code map rather than traversing in pause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/gc-tracer.cc

Issue 1478943003: Use WeakCells in the optimized code map rather than traversing in pause. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Facepalm. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/gc-tracer.cc

diff --git a/src/heap/gc-tracer.cc b/src/heap/gc-tracer.cc

index 7b0b1ac9d5fd5661e14877440c61c7dfa14959ab..609c9009d04bbcf9947658deb14e0f7d3e79e1f9 100644

--- a/src/heap/gc-tracer.cc

+++ b/src/heap/gc-tracer.cc

@@ -505,7 +505,6 @@ void GCTracer::PrintNVP() const {

"mark_weakrefs=%.1f "

"mark_globalhandles=%.1f "

"mark_codeflush=%.1f "

- "mark_optimizedcodemaps=%.1f "

"store_buffer_clear=%.1f "

"slots_buffer_clear=%.1f "

"sweep=%.2f "

@@ -574,7 +573,6 @@ void GCTracer::PrintNVP() const {

current_.scopes[Scope::MC_MARK_WEAK_REFERENCES],

current_.scopes[Scope::MC_MARK_GLOBAL_HANDLES],

current_.scopes[Scope::MC_MARK_CODE_FLUSH],

- current_.scopes[Scope::MC_MARK_OPTIMIZED_CODE_MAPS],

current_.scopes[Scope::MC_STORE_BUFFER_CLEAR],

current_.scopes[Scope::MC_SLOTS_BUFFER_CLEAR],

current_.scopes[Scope::MC_SWEEP],

« no previous file with comments | « src/heap/gc-tracer.h ('k') | src/heap/heap.h » ('j') | src/objects.cc » ('J')