Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/objects-inl.h

Issue 1478943003: Use WeakCells in the optimized code map rather than traversing in pause. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2018 matching lines...) Expand 10 before | Expand all | Expand 10 after
2029 2029
2030 void PropertyCell::set_property_details(PropertyDetails details) { 2030 void PropertyCell::set_property_details(PropertyDetails details) {
2031 set_property_details_raw(details.AsSmi()); 2031 set_property_details_raw(details.AsSmi());
2032 } 2032 }
2033 2033
2034 2034
2035 Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); } 2035 Object* WeakCell::value() const { return READ_FIELD(this, kValueOffset); }
2036 2036
2037 2037
2038 void WeakCell::clear() { 2038 void WeakCell::clear() {
2039 DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT); 2039 // Either the garbage collector is clearing the cell or we are simply
2040 // initializing the root empty weak cell.
2041 DCHECK(GetHeap()->gc_state() == Heap::MARK_COMPACT ||
2042 this == GetHeap()->empty_weak_cell());
2040 WRITE_FIELD(this, kValueOffset, Smi::FromInt(0)); 2043 WRITE_FIELD(this, kValueOffset, Smi::FromInt(0));
2041 } 2044 }
2042 2045
2043 2046
2044 void WeakCell::initialize(HeapObject* val) { 2047 void WeakCell::initialize(HeapObject* val) {
2045 WRITE_FIELD(this, kValueOffset, val); 2048 WRITE_FIELD(this, kValueOffset, val);
2046 Heap* heap = GetHeap(); 2049 Heap* heap = GetHeap();
2047 // We just have to execute the generational barrier here because we never 2050 // We just have to execute the generational barrier here because we never
2048 // mark through a weak cell and collect evacuation candidates when we process 2051 // mark through a weak cell and collect evacuation candidates when we process
2049 // all weak cells. 2052 // all weak cells.
(...skipping 5827 matching lines...) Expand 10 before | Expand all | Expand 10 after
7877 #undef WRITE_INT64_FIELD 7880 #undef WRITE_INT64_FIELD
7878 #undef READ_BYTE_FIELD 7881 #undef READ_BYTE_FIELD
7879 #undef WRITE_BYTE_FIELD 7882 #undef WRITE_BYTE_FIELD
7880 #undef NOBARRIER_READ_BYTE_FIELD 7883 #undef NOBARRIER_READ_BYTE_FIELD
7881 #undef NOBARRIER_WRITE_BYTE_FIELD 7884 #undef NOBARRIER_WRITE_BYTE_FIELD
7882 7885
7883 } // namespace internal 7886 } // namespace internal
7884 } // namespace v8 7887 } // namespace v8
7885 7888
7886 #endif // V8_OBJECTS_INL_H_ 7889 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698