Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 14789015: Build the Widevine CDM adapter on Win. (Closed)

Created:
7 years, 7 months ago by xhwang
Modified:
7 years, 7 months ago
Reviewers:
ddorwin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Build the Widevine CDM adapter on Win. When building the adapter we'll see LNK2019 error and LNK4075/LNK4088 warnings. These are expected. The linking will succeed regardless and the adapter will be generated. These errors/warnings will be resolved later. BUG=180260, 237636 R=ddorwin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198300

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/widevine/cdm/widevine_cdm.gyp View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
xhwang
PTAL
7 years, 7 months ago (2013-05-04 01:04:18 UTC) #1
ddorwin
lgtm
7 years, 7 months ago (2013-05-04 01:12:31 UTC) #2
xhwang
7 years, 7 months ago (2013-05-04 05:28:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r198300 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698