Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1478863005: [build] Fix msan after clang roll. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/standalone.gypi View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR. Please ping me once you change common.gypi back again.
5 years ago (2015-11-26 10:01:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478863005/1
5 years ago (2015-11-26 10:01:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 10:34:15 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58f4a052a1e0c6a4eff5cfdbc3c4761dc4adf781 Cr-Commit-Position: refs/heads/master@{#32326}
5 years ago (2015-11-26 10:34:53 UTC) #9
Nico
5 years ago (2015-11-26 15:11:22 UTC) #10
Message was sent while issue was closed.
lgtm, thanks

https://codereview.chromium.org/1478863005/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1478863005/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:578: '-fPIC',
upstream we added comments to remind us to remove them again:
https://chromium.googlesource.com/chromium/src/+/4fea0f71e935f43777c5f0c0b488...

Powered by Google App Engine
This is Rietveld 408576698