Handle cross-process transfers properly in ExtensionViewHost::OpenURLFromTab.

chrome/browser/extensions/extension_view_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_view_host.h"
 
 #include "base/strings/string_piece.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_view.h"
@@ skipping 128 matching lines @@
 bool ExtensionViewHost::IsBackgroundPage() const {
   DCHECK(view_);
   return false;
 }
 
 // content::WebContentsDelegate overrides:
 
 WebContents* ExtensionViewHost::OpenURLFromTab(
     WebContents* source,
     const OpenURLParams& params) {
+  // Supporting CURRENT_TAB is necessary for renderer-initiated, cross-site
+  // frame navigations with --isolate-extensions or --site-per-process.  These
+  // navigations cause cross-process transfers which utilize this function with
+  // CURRENT_TAB.  This means that the navigation should happen in the same
+  // ExtensionViewHost window.
+  bool is_transfer =
+      params.transferred_global_request_id != content::GlobalRequestID();
+  if (params.disposition == CURRENT_TAB && is_transfer)
+    return WebContentsDelegate::OpenURLFromTab(host_contents(), params);
+
   // Whitelist the dispositions we will allow to be opened.
   switch (params.disposition) {
     case SINGLETON_TAB:
     case NEW_FOREGROUND_TAB:
     case NEW_BACKGROUND_TAB:
     case NEW_POPUP:
     case NEW_WINDOW:
     case SAVE_TO_DISK:
     case OFF_THE_RECORD: {
       // Only allow these from hosts that are bound to a browser (e.g. popups).
@@ skipping 139 matching lines @@
                                 const content::NotificationSource& source,
                                 const content::NotificationDetails& details) {
   DCHECK_EQ(type, extensions::NOTIFICATION_EXTENSION_BACKGROUND_PAGE_READY);
   DCHECK(ExtensionSystem::Get(browser_context())
              ->runtime_data()
              ->IsBackgroundPageReady(extension()));
   LoadInitialURL();
 }
 
 }  // namespace extensions