Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1478863002: Handle cross-process transfers properly in ExtensionViewHost::OpenURLFromTab. (Closed)

Created:
5 years ago by alexmos
Modified:
5 years ago
Reviewers:
Devlin, Charlie Reis
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@isolate-extensions-OpenURLFromTab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle cross-process transfers properly in ExtensionViewHost::OpenURLFromTab. With --isolate-extensions or --site-per-process, cross-process navigation transfers involve calling OpenURLFromTab on the WebContents delegate with disposition CURRENT_TAB, but ExtensionViewHost wasn't handling this case. This caused web iframes embedded in browser action popups to be broken. This CL adds support for CURRENT_TAB to ExtensionViewHost::OpenURLFromTab for the case of such transfers. BUG=546267 Committed: https://crrev.com/9d25e9f1632aacfb5ac75f9efbdb52ec5708a7ef Cr-Commit-Position: refs/heads/master@{#362537}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 12

Patch Set 3 : Address Devlin's feedback #

Patch Set 4 : Fix license #

Messages

Total messages: 18 (8 generated)
alexmos
Devlin, can you please take a look? Also adding Charlie since he reviewed the prerequisite ...
5 years ago (2015-12-01 17:33:09 UTC) #3
Devlin
LGTM https://codereview.chromium.org/1478863002/diff/20001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc (right): https://codereview.chromium.org/1478863002/diff/20001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc#newcode730 chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:730: while (msg_queue.WaitForMessage(&status)) { Is this voodoo different than ...
5 years ago (2015-12-01 17:40:17 UTC) #4
Charlie Reis
Great. LGTM with Devlin's suggestions.
5 years ago (2015-12-01 18:05:41 UTC) #5
alexmos
Thanks for the quick review! https://codereview.chromium.org/1478863002/diff/20001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc (right): https://codereview.chromium.org/1478863002/diff/20001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc#newcode730 chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:730: while (msg_queue.WaitForMessage(&status)) { On ...
5 years ago (2015-12-01 18:09:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478863002/40001
5 years ago (2015-12-01 19:21:19 UTC) #9
Devlin
https://codereview.chromium.org/1478863002/diff/20001/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js File chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js (right): https://codereview.chromium.org/1478863002/diff/20001/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js#newcode1 chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js:1: // Copyright (c) 2015 The Chromium Authors. All rights ...
5 years ago (2015-12-01 19:59:23 UTC) #10
alexmos
https://codereview.chromium.org/1478863002/diff/20001/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js File chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js (right): https://codereview.chromium.org/1478863002/diff/20001/chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js#newcode1 chrome/test/data/extensions/api_test/browser_action/popup_with_iframe/popup.js:1: // Copyright (c) 2015 The Chromium Authors. All rights ...
5 years ago (2015-12-01 20:59:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478863002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478863002/60001
5 years ago (2015-12-01 21:01:06 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-01 22:49:58 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-01 22:50:36 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9d25e9f1632aacfb5ac75f9efbdb52ec5708a7ef
Cr-Commit-Position: refs/heads/master@{#362537}

Powered by Google App Engine
This is Rietveld 408576698