Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1478813002: Renames example_wm to mash_wm (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames example_wm to mash_wm Also, fixes wm_apptest and adds to list of tests to run. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/ef819da4dfaec81f11ed223b5377e2e3bff6692c Cr-Commit-Position: refs/heads/master@{#361801}

Patch Set 1 #

Patch Set 2 : update args for x #

Patch Set 3 : fix fontloader #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/main/main_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 5 chunks +9 lines, -8 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
sky
5 years ago (2015-11-25 19:01:14 UTC) #1
Ben Goodger (Google)
lgtm
5 years ago (2015-11-25 20:06:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478813002/20001
5 years ago (2015-11-25 20:12:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/146332)
5 years ago (2015-11-25 21:11:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478813002/40001
5 years ago (2015-11-25 21:29:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/136039)
5 years ago (2015-11-25 21:40:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478813002/40001
5 years ago (2015-11-25 21:43:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/136062)
5 years ago (2015-11-25 22:00:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478813002/60001
5 years ago (2015-11-25 22:14:27 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-26 00:18:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478813002/60001
5 years ago (2015-11-26 01:46:48 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-26 02:40:04 UTC) #24
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ef819da4dfaec81f11ed223b5377e2e3bff6692c Cr-Commit-Position: refs/heads/master@{#361801}
5 years ago (2015-11-26 02:41:35 UTC) #26
msw
5 years ago (2015-11-28 18:14:16 UTC) #28
Message was sent while issue was closed.
Looks like this broke the FYI waterfall.

Powered by Google App Engine
This is Rietveld 408576698