[Chromecast] Support software rendering when disable-gpu used

ui/ozone/platform/cast/ozone_platform_cast.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/cast/ozone_platform_cast.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "chromecast/public/cast_egl_platform.h"
 #include "chromecast/public/cast_egl_platform_shlib.h"
@@ skipping 62 matching lines @@
   }
   base::ScopedFD OpenClientNativePixmapDevice() const override {
     return base::ScopedFD();
   }
 
   void InitializeUI() override {
     overlay_manager_.reset(new OverlayManagerCast());
     cursor_factory_.reset(new CursorFactoryOzone());
     input_controller_ = CreateStubInputController();
     gpu_platform_support_host_.reset(CreateStubGpuPlatformSupportHost());
+
+    // Enable dummy software rendering support if GPU process disabled
+    if (base::CommandLine::ForCurrentProcess()->HasSwitch("disable-gpu"))

[derekjchow1, 2015/12/08 22:03:15]

define kDisableGpu

[slan, 2015/12/08 22:40:25]

+1

Although I'm afraid we might be overloading the switch. Do you intend to use the
switch declared here:

src/content/public/common/content_switches.h

If not, we should change this string. If so, I wish we could create a dependency
here, but that is almost certainly a layering violation...

[halliwell, 2015/12/08 23:27:56]

Indeed, I'm using the switch from content, but can't include the header :(

[derekjchow1, 2015/12/09 21:19:34]

Please redefine in a local anonymous namespace.

+      surface_factory_.reset(new SurfaceFactoryCast());
   }
   void InitializeGPU() override {
     surface_factory_.reset(new SurfaceFactoryCast(egl_platform_.Pass()));
     g_gpu_platform_support.Get() =
         make_scoped_ptr(new GpuPlatformSupportCast(surface_factory_.get()));
   }
 
  private:
   scoped_ptr<CastEglPlatform> egl_platform_;
   scoped_ptr<SurfaceFactoryCast> surface_factory_;
   scoped_ptr<CursorFactoryOzone> cursor_factory_;
   scoped_ptr<InputController> input_controller_;
   scoped_ptr<GpuPlatformSupportHost> gpu_platform_support_host_;
   scoped_ptr<OverlayManagerOzone> overlay_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(OzonePlatformCast);
 };
 
 }  // namespace
 
 OzonePlatform* CreateOzonePlatformCast() {
   const std::vector<std::string>& argv =
       base::CommandLine::ForCurrentProcess()->argv();
   scoped_ptr<chromecast::CastEglPlatform> platform(
       chromecast::CastEglPlatformShlib::Create(argv));
   return new OzonePlatformCast(platform.Pass());
 }
 
 }  // namespace ui