Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Issue 1478713002: Set the constant pool size to 0 on architectures that do not use it. (Closed)

Created:
5 years ago by titzer
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set the constant pool size to 0 on architectures that do not use it. Turns out we've been putting garbage into code->constant_pool_offset for quite some time. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/9917f3375ff4b38df1746fccea6d48d33e12ea35 Cr-Commit-Position: refs/heads/master@{#32269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years ago (2015-11-25 12:33:50 UTC) #1
Jakob Kummerow
lgtm
5 years ago (2015-11-25 12:36:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478713002/1
5 years ago (2015-11-25 12:56:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 13:10:31 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 13:10:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9917f3375ff4b38df1746fccea6d48d33e12ea35
Cr-Commit-Position: refs/heads/master@{#32269}

Powered by Google App Engine
This is Rietveld 408576698