Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4806)

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 1478643002: Refactor media out of WebContentsImpl to MediaWebContentsObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove cruft. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper.h
diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h
index 3f89350ecb957b68677eb36d7670d5a7a600ecb9..9e01110633939cbac3a0bf9bdf159b058204fcd5 100644
--- a/chrome/browser/engagement/site_engagement_helper.h
+++ b/chrome/browser/engagement/site_engagement_helper.h
@@ -130,6 +130,7 @@ class SiteEngagementHelper
public:
MediaTracker(SiteEngagementHelper* helper,
content::WebContents* web_contents);
+ ~MediaTracker() override;
private:
friend class SiteEngagementHelperTest;
@@ -137,13 +138,13 @@ class SiteEngagementHelper
void TrackingStarted() override;
// content::WebContentsObserver overrides.
- void MediaStartedPlaying() override;
- void MediaPaused() override;
+ void MediaStartedPlaying(const MediaPlayerId& id) override;
+ void MediaPaused(const MediaPlayerId& id) override;
void WasShown() override;
void WasHidden() override;
bool is_hidden_;
- bool is_playing_;
+ std::vector<MediaPlayerId> active_media_players_;
};
explicit SiteEngagementHelper(content::WebContents* web_contents);

Powered by Google App Engine
This is Rietveld 408576698