chrome/browser/engagement/site_engagement_helper_unittest.cc - Issue 1478643002: Refactor media out of WebContentsImpl to MediaWebContentsObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 1478643002: Refactor media out of WebContentsImpl to MediaWebContentsObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.cc ('k') | chromecast/browser/cast_content_window.h » ('j') | content/test/web_contents_observer_sanity_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_helper_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc

index 6b8fee78c17ab0e2c63965077b613b2d9f7fe0e0..d05857eeb9ddb1fe3ec6f6490f2fbc8e117efcde 100644

--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc

@@ -53,11 +53,13 @@ class SiteEngagementHelperTest : public BrowserWithTestWindowTest {

}

void MediaStartedPlaying(SiteEngagementHelper* helper) {

- helper->media_tracker_.MediaStartedPlaying();

+ helper->media_tracker_.MediaStartedPlaying(

+ content::WebContentsObserver::MediaPlayerId(nullptr, 1));

}

void MediaPaused(SiteEngagementHelper* helper) {

- helper->media_tracker_.MediaPaused();

+ helper->media_tracker_.MediaPaused(

+ content::WebContentsObserver::MediaPlayerId(nullptr, 1));

}

// Set a pause timer on the input tracker for test purposes.