Convert enable_pre_sync_backup flag to new flags system.

Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.

Committed: https://crrev.com/bc4bccdacc16ccdf314870049033e03c463e478e
Cr-Commit-Position: refs/heads/master@{#362284}

[brettw, 2015-11-25 23:33:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 23:36:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478623004/20001

[commit-bot: I haz the power, 2015-11-26 00:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:13:04]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[brettw, 2015-11-26 18:12:57]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-26 18:13:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478623004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478623004/40001

[brettw, 2015-11-26 18:15:32]

Description was changed from

==========
Convert sync driver flag to new flags system.

This flag is very isolated, so it creates a new sync_driver_features target that
generates a header file for it.
==========

to

==========
Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system.
There is now a generated header for the #define rather than a global define.
==========

[brettw, 2015-11-26 18:15:32]

brettw@chromium.org changed reviewers:
+ zea@chromium.org

[commit-bot: I haz the power, 2015-11-26 18:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 18:24:15]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[brettw, 2015-11-26 19:34:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-26 19:35:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478623004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478623004/60001

[commit-bot: I haz the power, 2015-11-26 23:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 23:48:08]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2015-11-30 20:02:20]

LGTM, nice!

[brettw, 2015-11-30 20:10:38]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-30 20:12:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478623004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478623004/60001

[commit-bot: I haz the power, 2015-12-01 00:10:38]

Description was changed from

==========
Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system.
There is now a generated header for the #define rather than a global define.
==========

to

==========
Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system.
There is now a generated header for the #define rather than a global define.
==========

[commit-bot: I haz the power, 2015-12-01 00:10:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-01 00:11:19]

Description was changed from

==========
Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system.
There is now a generated header for the #define rather than a global define.
==========

to

==========
Convert enable_pre_sync_backup flag to new flags system.

This flag's usage is very isolated so is a good candidate for the new system.
There is now a generated header for the #define rather than a global define.

Committed: https://crrev.com/bc4bccdacc16ccdf314870049033e03c463e478e
Cr-Commit-Position: refs/heads/master@{#362284}
==========

[commit-bot: I haz the power, 2015-12-01 00:11:19]

Patchset 4 (id:??) landed as
https://crrev.com/bc4bccdacc16ccdf314870049033e03c463e478e
Cr-Commit-Position: refs/heads/master@{#362284}

[brettw, 2015-12-01 00:35:03]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1485933002/ by brettw@chromium.org.

The reason for reverting is: Busted iOS
http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/30182/ste....