Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 1478623003: [heap] Count bits in markbit cell instead of using a table. (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Count bits in markbit cell instead of using a table. Iterating live objects using mark bits is memory bound and already pretty heavy on the cache as we always need to look at the mark bits, the objects (payload), and their maps. This CL changes the object start computation from a table lookup, which was yet another memory location, to a CPU-bound computation. BUG=chromium:524425 LOG=N Committed: https://crrev.com/206ba3124573df5a530779af721293853711ad67 Cr-Commit-Position: refs/heads/master@{#32291}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -395 lines) Patch
M src/heap/mark-compact.cc View 7 chunks +20 lines, -395 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Lippautz
Should be supported starting from armv5 https://en.wikipedia.org/wiki/Find_first_set Slightly improves the average pause time (~8%) for ...
5 years ago (2015-11-25 14:36:54 UTC) #3
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-25 16:33:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478623003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478623003/20001
5 years ago (2015-11-25 16:33:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-11-25 17:31:31 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 17:32:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/206ba3124573df5a530779af721293853711ad67
Cr-Commit-Position: refs/heads/master@{#32291}

Powered by Google App Engine
This is Rietveld 408576698