Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: src/runtime/runtime-liveedit.cc

Issue 1478613004: [debugger] track debugger feature usage via histogram. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/heap-profiler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/liveedit.h" 10 #include "src/debug/liveedit.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 // Compares 2 strings line-by-line, then token-wise and returns diff in form 222 // Compares 2 strings line-by-line, then token-wise and returns diff in form
223 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list 223 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list
224 // of diff chunks. 224 // of diff chunks.
225 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) { 225 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) {
226 HandleScope scope(isolate); 226 HandleScope scope(isolate);
227 CHECK(isolate->debug()->live_edit_enabled()); 227 CHECK(isolate->debug()->live_edit_enabled());
228 DCHECK(args.length() == 2); 228 DCHECK(args.length() == 2);
229 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0); 229 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0);
230 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1); 230 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1);
231 231
232 isolate->debug()->feature_tracker()->Track(DebugFeatureTracker::kLiveEdit);
233
232 return *LiveEdit::CompareStrings(s1, s2); 234 return *LiveEdit::CompareStrings(s1, s2);
233 } 235 }
234 236
235 237
236 // Restarts a call frame and completely drops all frames above. 238 // Restarts a call frame and completely drops all frames above.
237 // Returns true if successful. Otherwise returns undefined or an error message. 239 // Returns true if successful. Otherwise returns undefined or an error message.
238 RUNTIME_FUNCTION(Runtime_LiveEditRestartFrame) { 240 RUNTIME_FUNCTION(Runtime_LiveEditRestartFrame) {
239 HandleScope scope(isolate); 241 HandleScope scope(isolate);
240 CHECK(isolate->debug()->live_edit_enabled()); 242 CHECK(isolate->debug()->live_edit_enabled());
241 DCHECK(args.length() == 2); 243 DCHECK(args.length() == 2);
(...skipping 17 matching lines...) Expand all
259 // We don't really care what the inlined frame index is, since we are 261 // We don't really care what the inlined frame index is, since we are
260 // throwing away the entire frame anyways. 262 // throwing away the entire frame anyways.
261 const char* error_message = LiveEdit::RestartFrame(it.frame()); 263 const char* error_message = LiveEdit::RestartFrame(it.frame());
262 if (error_message) { 264 if (error_message) {
263 return *(isolate->factory()->InternalizeUtf8String(error_message)); 265 return *(isolate->factory()->InternalizeUtf8String(error_message));
264 } 266 }
265 return heap->true_value(); 267 return heap->true_value();
266 } 268 }
267 } // namespace internal 269 } // namespace internal
268 } // namespace v8 270 } // namespace v8
OLDNEW
« no previous file with comments | « src/profiler/heap-profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698