Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1478503003: EDK: Convert most uses of PlatformHandleVector to std::vector<ScopedPlatformHandle>. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Convert most uses of PlatformHandleVector to std::vector<ScopedPlatformHandle>. (And ScopedPlatformHandleVectorPtr to std::unique_ptr<std::vector<ScopedPlatformHandle>>.) There are a few more uses, but this change is already too big. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6f395e3de5c96a490d9eaa33dc6dfdd42f35dcd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -170 lines) Patch
M mojo/edk/embedder/platform_channel_pair_unittest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils.h View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/edk/system/channel.h View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/edk/system/channel.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 3 chunks +12 lines, -9 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 5 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 7 chunks +11 lines, -7 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M mojo/edk/system/raw_channel.h View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 9 chunks +24 lines, -21 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 10 chunks +25 lines, -23 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/transport_data.h View 5 chunks +9 lines, -7 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-11-25 02:37:18 UTC) #1
vardhan
lgtm
5 years ago (2015-11-25 20:05:07 UTC) #2
viettrungluu
5 years ago (2015-11-25 20:24:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f395e3de5c96a490d9eaa33dc6dfdd42f35dcd4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698