Update pdfium_tests.py to run pdfium tests with Dr. Memory on buildbots

Update pdfium_tests.py to run pdfium tests with Dr. Memory on buildbots

- update pdfium_tests.py to setup Dr. Memory so it can be used directly without
  pdfium_tests.bat on buildbots

R=thestig@chromium.org
BUG=PDFium:238
Committed: https://pdfium.googlesource.com/pdfium/+/abea9d857e8e197d0095940f882b0db6a785d825

[Lei Zhang, 2015-11-24 19:36:56]

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
tools/drmemory/scripts/pdfium_tests.py:65: subprocess.call([drmem_sfx,
"-o"+drmem_dir, "-y"], 0)
Just to double check, this is suppose to run:
drmemory-windows-sfx.exe -osomedir -y

And not:
drmemory-windows-sfx.exe -o somedir -y ?

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
tools/drmemory/scripts/pdfium_tests.py:65: subprocess.call([drmem_sfx,
"-o"+drmem_dir, "-y"], 0)
I believe python style prefers foo + bar over foo+bar.

[zhaoqin, 2015-11-24 19:47:23]

zhaoqin@google.com changed reviewers:
+ zhaoqin@google.com

[zhaoqin, 2015-11-24 19:47:24]

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
tools/drmemory/scripts/pdfium_tests.py:65: subprocess.call([drmem_sfx,
"-o"+drmem_dir, "-y"], 0)
On 2015/11/24 19:36:56, Lei Zhang wrote:
> Just to double check, this is suppose to run:
> drmemory-windows-sfx.exe -osomedir -y
> 
> And not:
> drmemory-windows-sfx.exe -o somedir -y ?

strange enough, there is no space after -o.

Usage: 7zSFX [<command>] [<switches>...]

<Commands>
  l: List contents of archive
  t: Test integrity of archive
  x: eXtract files with full pathname (default)
<Switches>
  -o{Directory}: set Output directory
  -p{Password}: set Password
  -y: assume Yes on all queries

https://codereview.chromium.org/1478453002/diff/1/tools/drmemory/scripts/pdfi...
tools/drmemory/scripts/pdfium_tests.py:65: subprocess.call([drmem_sfx,
"-o"+drmem_dir, "-y"], 0)
On 2015/11/24 19:36:56, Lei Zhang wrote:
> I believe python style prefers foo + bar over foo+bar.

Done.

[Lei Zhang, 2015-11-24 20:07:23]

lgtm with a nit.

re: no space - ya, very DOS 6.0. ;)

https://codereview.chromium.org/1478453002/diff/20001/tools/drmemory/scripts/...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1478453002/diff/20001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:58: # Setup Dr. Memory if not yet
if it's not set up yet.

[zhaoqin1, 2015-11-24 20:23:19]

Committed patchset #3 (id:40001) manually as
abea9d857e8e197d0095940f882b0db6a785d825 (presubmit successful).