chrome/browser/storage/durable_storage_permission_context.h - Issue 1478433002: Permissions: Move common logic from DecidePermission to RequestPermission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage/durable_storage_permission_context.h

Issue 1478433002: Permissions: Move common logic from DecidePermission to RequestPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@innoinherit

Patch Set: Rebase / git cl format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc ('k') | chrome/browser/storage/durable_storage_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage/durable_storage_permission_context.h

diff --git a/chrome/browser/storage/durable_storage_permission_context.h b/chrome/browser/storage/durable_storage_permission_context.h

index 830de530c5e732711f626f7108fcbcc523ad6576..7f30302abd2dcb45a4aecc6fb7db3f93ebeb6bbc 100644

--- a/chrome/browser/storage/durable_storage_permission_context.h

+++ b/chrome/browser/storage/durable_storage_permission_context.h

@@ -15,6 +15,7 @@ class DurableStoragePermissionContext : public PermissionContextBase {

explicit DurableStoragePermissionContext(Profile* profile);

~DurableStoragePermissionContext() override = default;

+ // PermissionContextBase implementation.

// Grant if requesting_origin is bookmarked or already granted.

void DecidePermission(content::WebContents* web_contents,

const PermissionRequestID& id,

@@ -22,11 +23,9 @@ class DurableStoragePermissionContext : public PermissionContextBase {

const GURL& embedding_origin,

bool user_gesture,

const BrowserPermissionCallback& callback) override;

void UpdateContentSetting(const GURL& requesting_origin,

const GURL& embedding_origin,

ContentSetting content_setting) override;

bool IsRestrictedToSecureOrigins() const override;

private: