Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2609)

Unified Diff: chrome/browser/media/protected_media_identifier_permission_context.cc

Issue 1478433002: Permissions: Move common logic from DecidePermission to RequestPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@innoinherit
Patch Set: Rebase / git cl format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/protected_media_identifier_permission_context.cc
diff --git a/chrome/browser/media/protected_media_identifier_permission_context.cc b/chrome/browser/media/protected_media_identifier_permission_context.cc
index 5933f3b0d367279bceb9f1e6b14cc6f61b8fbdd4..0ac7e815404e97a6888c796c7eec575ca5c1b2d1 100644
--- a/chrome/browser/media/protected_media_identifier_permission_context.cc
+++ b/chrome/browser/media/protected_media_identifier_permission_context.cc
@@ -48,6 +48,7 @@ ProtectedMediaIdentifierPermissionContext::
~ProtectedMediaIdentifierPermissionContext() {
}
+#if defined(OS_CHROMEOS)
void ProtectedMediaIdentifierPermissionContext::RequestPermission(
content::WebContents* web_contents,
const PermissionRequestID& id,
@@ -93,7 +94,6 @@ void ProtectedMediaIdentifierPermissionContext::RequestPermission(
DCHECK_EQ(CONTENT_SETTING_ASK, content_setting);
-#if defined(OS_CHROMEOS)
// Since the dialog is modal, we only support one prompt per |web_contents|.
// Reject the new one if there is already one pending. See
// http://crbug.com/447005
@@ -114,11 +114,8 @@ void ProtectedMediaIdentifierPermissionContext::RequestPermission(
requesting_origin, embedding_origin, callback));
pending_requests_.insert(
std::make_pair(web_contents, std::make_pair(widget, id)));
-#else
- PermissionContextBase::RequestPermission(web_contents, id, requesting_origin,
- user_gesture, callback);
-#endif
}
+#endif // defined(OS_CHROMEOS)
ContentSetting ProtectedMediaIdentifierPermissionContext::GetPermissionStatus(
const GURL& requesting_origin,

Powered by Google App Engine
This is Rietveld 408576698