chrome/browser/geolocation/geolocation_permission_context.cc - Issue 1478433002: Permissions: Move common logic from DecidePermission to RequestPermission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.cc

Issue 1478433002: Permissions: Move common logic from DecidePermission to RequestPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@innoinherit

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/permissions/permission_context_base.cc » ('j') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context.cc b/chrome/browser/geolocation/geolocation_permission_context.cc

index bb29c8862dda05a95c2f39cabaf1df8323923df5..fb3893488724e838eb63227770a0389593f094ae 100644

--- a/chrome/browser/geolocation/geolocation_permission_context.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context.cc

@@ -23,6 +23,7 @@ GeolocationPermissionContext::GeolocationPermissionContext(

GeolocationPermissionContext::~GeolocationPermissionContext() {

}

+// TODO: CHECK THIS

mlamouri (slow - plz ping) 2015/11/26 12:45:49 I think there is nothing to do here.

johnme 2015/11/26 18:28:48 Removed TODO.

void GeolocationPermissionContext::DecidePermission(

content::WebContents* web_contents,

const PermissionRequestID& id,

« no previous file with comments | « no previous file | chrome/browser/permissions/permission_context_base.cc » ('j') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('J')