Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/libaddressinput/chromium/cpp/src/util/json.h

Issue 147843008: libaddressinput - Don't make transient copies of entire JSON rule dictionaries (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libaddressinput/chromium/json.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/chromium/cpp/src/util/json.h
diff --git a/third_party/libaddressinput/chromium/cpp/src/util/json.h b/third_party/libaddressinput/chromium/cpp/src/util/json.h
index 9af7f1cd0cbaddbf8d509d50ae0a27388675c1d4..c7284728c99561371d973e48d82f6e398ef05d4a 100644
--- a/third_party/libaddressinput/chromium/cpp/src/util/json.h
+++ b/third_party/libaddressinput/chromium/cpp/src/util/json.h
@@ -50,7 +50,8 @@ class Json {
// Sets |value| to the dictionary for |key| if it exists and has a dictionary
// value. Returns false if the key doesn't exist or doesn't correspond to a
// dictionary. The JSON object must be parsed successfully in ParseObject()
- // before invoking this method.
+ // before invoking this method. |value| is only guaranteed to be valid as long
+ // as |this| is valid.
virtual bool GetJsonValueForKey(const std::string& key,
scoped_ptr<Json>* value) const = 0;
« no previous file with comments | « no previous file | third_party/libaddressinput/chromium/json.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698