Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: ppapi/api/ppb_file_ref.idl

Issue 14784002: Move DirectoryReader::ReadEntries to FileRef::ReadDirectoryEntries (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix naclsdk Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/ppb_file_ref.idl
diff --git a/ppapi/api/ppb_file_ref.idl b/ppapi/api/ppb_file_ref.idl
index cc08f8ea429fc494d412c4421c8fb85aa4d13c95..02d994b942a51da5051fdf7a7890ae1f77499deb 100644
--- a/ppapi/api/ppb_file_ref.idl
+++ b/ppapi/api/ppb_file_ref.idl
@@ -185,5 +185,21 @@ interface PPB_FileRef {
int32_t Query([in] PP_Resource file_ref,
[out] PP_FileInfo info,
[in] PP_CompletionCallback callback);
+
+ /* Reads all entries in a directory.
dmichael (off chromium) 2013/05/02 19:43:54 nit: please use doxygen comment style: /** (see ot
hamaji 2013/05/02 20:14:49 Done.
+ *
+ * @param[in] file_ref A <code>PP_Resource</code> corresponding to a directory
+ * reference.
+ * @param[in] output An output array which will receive
+ * <code>PP_DirectoryEntry</code> objects on success.
+ * @param[in] callback A <code>PP_CompletionCallback</code> to run on
+ * completion.
+ *
+ * @return An int32_t containing an error code from <code>pp_errors.h</code>.
+ */
+ [version=1.1]
teravest 2013/05/02 17:32:10 You'll want to make this version 1.2=M29 unless th
hamaji 2013/05/02 18:49:40 We want this real soon and I'd like to land this b
+ int32_t ReadEntries([in] PP_Resource file_ref,
+ [in] PP_ArrayOutput output,
+ [in] PP_CompletionCallback callback);
dmichael (off chromium) 2013/05/02 19:43:54 This is a little bit tricky... We would usually r
hamaji 2013/05/02 20:14:49 OK, I'll do my best to land this soon.
};

Powered by Google App Engine
This is Rietveld 408576698