Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5461)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu_button.h

Issue 1478303003: Converted all Views to use an InkDropDelegate instead of a InkDropAnimationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged with master / https://codereview.chromium.org/1494433003. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/app_menu_button.h
diff --git a/chrome/browser/ui/views/toolbar/app_menu_button.h b/chrome/browser/ui/views/toolbar/app_menu_button.h
index 2536f543d92fb919f799695ecad511d54f2bbfa3..0ef292e75c10fcccb0d050d889202d4e387a6e06 100644
--- a/chrome/browser/ui/views/toolbar/app_menu_button.h
+++ b/chrome/browser/ui/views/toolbar/app_menu_button.h
@@ -18,7 +18,6 @@ class AppMenu;
class AppMenuModel;
namespace views {
-class InkDropAnimationController;
class LabelButtonBorder;
class MenuListener;
}
@@ -85,7 +84,6 @@ class AppMenuButton : public views::InkDropHost,
std::set<ui::Clipboard::FormatType>* format_types) override;
bool AreDropTypesRequired() override;
bool CanDrop(const ui::OSExchangeData& data) override;
- void Layout() override;
void OnDragEntered(const ui::DropTargetEvent& event) override;
int OnDragUpdated(const ui::DropTargetEvent& event) override;
void OnDragExited() override;
@@ -98,9 +96,6 @@ class AppMenuButton : public views::InkDropHost,
// Only used in MD.
AppMenuIconPainter::Severity severity_;
- // Animation controller for the ink drop ripple effect.
- scoped_ptr<views::InkDropAnimationController> ink_drop_animation_controller_;
-
// Our owning toolbar view.
ToolbarView* toolbar_view_;
@@ -125,6 +120,9 @@ class AppMenuButton : public views::InkDropHost,
// a maximized state to extend to the full window width.
int margin_trailing_;
+ // Controls the visual feedback for the button state.
+ scoped_ptr<views::InkDropDelegate> ink_drop_delegate_;
varkha 2015/12/09 21:23:36 Do you need a forward declaration for InkDropDeleg
bruthig 2015/12/11 22:09:45 Done.
+
// Used to spawn weak pointers for delayed tasks to open the overflow menu.
base::WeakPtrFactory<AppMenuButton> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698