Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 14783015: Fix performance regression after adding inlining support for operators, [], and []=. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 22723)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -630,10 +630,7 @@
void use(HInstruction argument) {
if (isGenerateAtUseSite(argument)) {
visitExpression(argument);
- } else if (argument is HCheck && argument.isControlFlow()) {
- // A [HCheck] that has control flow can never be used as an
- // expression and may not have a name. Therefore we just use the
- // checked instruction.
+ } else if (argument is HCheck && !variableNames.hasName(argument)) {
HCheck check = argument;
use(check.checkedInput);
} else {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698