Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 14783015: Fix performance regression after adding inlining support for operators, [], and []=. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (revision 22723)
+++ sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (working copy)
@@ -215,9 +215,13 @@
// Returns whether an invocation of [selector] on [receiver] will throw a
// [ArgumentError] if the argument is not of the right type.
- bool willThrowArgumentError(Selector selector, HInstruction receiver) {
+ bool willThrowArgumentError(Selector selector,
+ HInstruction receiver,
+ HType speculativeType) {
if (receiver != null && (receiver.isInteger() || receiver.isString())) {
- return selector.isOperator() && selector.name != const SourceString('==');
+ return selector.isOperator()
+ && selector.name != const SourceString('==')
+ && (speculativeType.isNumber() && !speculativeType.isInteger());
}
return false;
}
@@ -290,7 +294,7 @@
receiverSelectorOnThrow = selector;
willThrow = true;
}
- } else if (willThrowArgumentError(selector, receiver)) {
+ } else if (willThrowArgumentError(selector, receiver, speculativeType)) {
willThrow = true;
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698