Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14783007: Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inlin… (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
ojan
CC:
blink-reviews, jchaffraix+rendering
Visibility:
Public.

Description

Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box. Merges http://trac.webkit.org/changeset/149450 by enrica. When computing ascent and descent we need to take into account the baseline type. RootInlineBox::ascentAndDescentForBox failed to do that in few cases. BUG=none TEST=layout test, but note that the layout test doesn't show up correctly on retina chromes due to http://crbug.com/238081 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149708

Patch Set 1 #

Patch Set 2 : no baseline #

Patch Set 3 : rebase #

Patch Set 4 : how do i baseline durr #

Patch Set 5 : foo #

Patch Set 6 : ffffff #

Patch Set 7 : fffffffffffff #

Patch Set 8 : fffffffffffffffffffffffffffffffff #

Patch Set 9 : ffffffffffffffffffffffffffffffffffffffffffffffffffffffffff #

Patch Set 10 : missing? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Nico
r? (This is the first time I'm landing a CL with a new layout test ...
7 years, 7 months ago (2013-05-04 22:51:03 UTC) #1
ojan
lgtm This is still the best practice. Only catch is that you might want to ...
7 years, 7 months ago (2013-05-05 02:10:18 UTC) #2
Nico
Thanks! Removed the mac baseline from this CL, like advised.
7 years, 7 months ago (2013-05-05 20:58:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/5001
7 years, 7 months ago (2013-05-05 20:58:56 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-05 20:58:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/8002
7 years, 7 months ago (2013-05-05 21:16:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6742
7 years, 7 months ago (2013-05-05 21:52:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/16001
7 years, 7 months ago (2013-05-05 23:55:36 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6752
7 years, 7 months ago (2013-05-06 00:30:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/27005
7 years, 7 months ago (2013-05-06 00:49:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/34001
7 years, 7 months ago (2013-05-06 01:05:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/35001
7 years, 7 months ago (2013-05-06 01:26:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/30007
7 years, 7 months ago (2013-05-06 01:57:22 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6768
7 years, 7 months ago (2013-05-06 02:30:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/30007
7 years, 7 months ago (2013-05-06 03:36:32 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6777
7 years, 7 months ago (2013-05-06 04:05:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14783007/30007
7 years, 7 months ago (2013-05-06 04:09:52 UTC) #17
commit-bot: I haz the power
Change committed as 149708
7 years, 7 months ago (2013-05-06 04:33:51 UTC) #18
Dirk Pranke
7 years, 7 months ago (2013-05-06 19:15:36 UTC) #19
Message was sent while issue was closed. 
On 2013/05/06 04:33:51, I haz the power (commit-bot) wrote:
> Change committed as 149708

A bit late, but is there a reason this needs to be a pixel test and can't be a
reftest?

Powered by Google App Engine
This is Rietveld 408576698