Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1478283002: Less type conversion for NinePieceImage painting (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, slimming-paint-reviews_chromium.org, danakj, Rik, f(malita), Justin Novosad, blink-reviews-paint_chromium.org, blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Less type conversion for NinePieceImage painting Avoid float -> int -> float conversion when passing through the GraphicsContext layer, the ints are immediately converted back to floats anyway in GraphicsContext::drawTiledImage(). No functional change expected as along as the position of the NinePieceGrid is pixel-aligned, but bug is 66498 moving along and will enable sub-pixel positioning of the background image geometries. BUG=561519 Committed: https://crrev.com/31ab6a1707930cf411a9893fa46b3f97b3147450 Cr-Commit-Position: refs/heads/master@{#362350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478283002/1
5 years ago (2015-11-27 13:23:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 14:25:56 UTC) #5
davve
Plumbing preparation for your sub-pixel patch and my other patches depending on that.
5 years ago (2015-11-27 14:38:03 UTC) #8
eae
LGTM
5 years ago (2015-12-01 03:14:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478283002/1
5 years ago (2015-12-01 03:14:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 04:48:26 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 04:49:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31ab6a1707930cf411a9893fa46b3f97b3147450
Cr-Commit-Position: refs/heads/master@{#362350}

Powered by Google App Engine
This is Rietveld 408576698