Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java

Issue 1478163002: [Cast,Android,Presentation API] Split CastRouteController into session and media routes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed some unnecessary changes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
index 13536c0efecf5069478188277bba639db9aa3b38..0e761a08f84242cc6c09b217a9d593f8f07f3add 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
@@ -158,7 +158,6 @@ public class CastRouteController implements RouteController, MediaNotificationLi
private String mApplicationStatus;
private ApplicationMetadata mApplicationMetadata;
private boolean mStoppingApplication;
- private boolean mDetached;
private MediaNotificationInfo.Builder mNotificationBuilder;
private RemoteMediaPlayer mMediaPlayer;
@@ -255,13 +254,6 @@ public class CastRouteController implements RouteController, MediaNotificationLi
}
}
- public CastRouteController createJoinedController(String mediaRouteId, String origin, int tabId,
- MediaSource source) {
- return new CastRouteController(mApiClient, mSessionId, mApplicationMetadata,
- mApplicationStatus, mCastDevice, mediaRouteId, origin, tabId, source,
- mRouteDelegate);
- }
-
/**
* @return the id of the Cast session controlled by the route.
*/
@@ -315,17 +307,6 @@ public class CastRouteController implements RouteController, MediaNotificationLi
return mTabId;
}
- @Override
- public void markDetached() {
- mDetached = true;
- }
-
- @Override
- public boolean isDetached() {
- return mDetached;
- }
-
-
/////////////////////////////////////////////////////////////////////////////////////////////
// MediaNotificationListener implementation.
@@ -402,15 +383,11 @@ public class CastRouteController implements RouteController, MediaNotificationLi
mSessionId = null;
mApiClient = null;
- mRouteDelegate.onRouteClosed(CastRouteController.this);
+ mRouteDelegate.onRouteClosed(getRouteId());
mStoppingApplication = false;
- // The detached route will be closed only if another route joined
- // the same session so it will take over the notification.
- if (!mDetached) {
- MediaNotificationManager.hide(
- mTabId, R.id.presentation_notification);
- }
+ MediaNotificationManager.hide(
+ mTabId, R.id.presentation_notification);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698