Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1478113002: Do not remove write barriers for stores of old space references in most recent old space allocation. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not remove write barriers for stores of old space references in most recent old space allocation. BUG=chromium:561449 LOG=n Committed: https://crrev.com/369778ec55a63ebe51e8fa8497edb5b681069b9b Cr-Commit-Position: refs/heads/master@{#32368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ulan
lgtm
5 years ago (2015-11-26 12:38:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478113002/1
5 years ago (2015-11-27 07:50:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8216)
5 years ago (2015-11-27 07:53:44 UTC) #7
Benedikt Meurer
LGTM (rubberstamped)
5 years ago (2015-11-27 10:47:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1478113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1478113002/1
5 years ago (2015-11-27 10:50:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 11:58:38 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/369778ec55a63ebe51e8fa8497edb5b681069b9b Cr-Commit-Position: refs/heads/master@{#32368}
5 years ago (2015-11-27 11:59:11 UTC) #15
Hannes Payer (out of office)
5 years ago (2015-11-30 13:06:02 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1482973003/ by hpayer@chromium.org.

The reason for reverting is: Broken canary. Trying to find out root cause..

Powered by Google App Engine
This is Rietveld 408576698