content/child/service_worker/service_worker_provider_context.cc - Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_provider_context.cc

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: return null in Create/Adopt Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/service_worker/service_worker_provider_context.cc

diff --git a/content/child/service_worker/service_worker_provider_context.cc b/content/child/service_worker/service_worker_provider_context.cc

index 44e567a65f8b12a8bcd72e4a6122114711747b04..ffabed0fe042736fc6d5e26f728fedefc95e252b 100644

--- a/content/child/service_worker/service_worker_provider_context.cc

+++ b/content/child/service_worker/service_worker_provider_context.cc

@@ -57,6 +57,8 @@ class ServiceWorkerProviderContext::ControlleeDelegate

void SetController(

scoped_ptr<ServiceWorkerHandleReference> controller) override {

DCHECK(registration_);

+ DCHECK(!controller ||

+ controller->handle_id() != kInvalidServiceWorkerHandleId);

controller_ = controller.Pass();

}

« no previous file with comments | « content/child/service_worker/service_worker_handle_reference.cc ('k') | no next file » | no next file with comments »