Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: content/child/service_worker/service_worker_handle_reference.h

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: return null in Create/Adopt Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_handle_reference.h
diff --git a/content/child/service_worker/service_worker_handle_reference.h b/content/child/service_worker/service_worker_handle_reference.h
index 81305cd0781f7ef8d26e0be7690112269a826ab2..c81e3ece75d80dc2847a13d6dfe253d98369c06d 100644
--- a/content/child/service_worker/service_worker_handle_reference.h
+++ b/content/child/service_worker/service_worker_handle_reference.h
@@ -19,12 +19,14 @@ class ThreadSafeSender;
// or decrement the reference count to the browser process.
class CONTENT_EXPORT ServiceWorkerHandleReference {
public:
- // Creates a new ServiceWorkerHandleReference and increments ref-count.
+ // Creates a new ServiceWorkerHandleReference and increments ref-count. If
+ // the handle id is kInvalidServiceWorkerHandleId, returns null instead.
static scoped_ptr<ServiceWorkerHandleReference> Create(
const ServiceWorkerObjectInfo& info,
ThreadSafeSender* sender);
- // Creates a new ServiceWorkerHandleReference by adopting a ref-count.
+ // Creates a new ServiceWorkerHandleReference by adopting a ref-count. If
+ // the handle id is kInvalidServiceWorkerHandleId, returns null instead.
static scoped_ptr<ServiceWorkerHandleReference> Adopt(
const ServiceWorkerObjectInfo& info,
ThreadSafeSender* sender);

Powered by Google App Engine
This is Rietveld 408576698