Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: content/child/service_worker/service_worker_provider_context.cc

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix controller Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_provider_context.cc
diff --git a/content/child/service_worker/service_worker_provider_context.cc b/content/child/service_worker/service_worker_provider_context.cc
index 44e567a65f8b12a8bcd72e4a6122114711747b04..ffabed0fe042736fc6d5e26f728fedefc95e252b 100644
--- a/content/child/service_worker/service_worker_provider_context.cc
+++ b/content/child/service_worker/service_worker_provider_context.cc
@@ -57,6 +57,8 @@ class ServiceWorkerProviderContext::ControlleeDelegate
void SetController(
scoped_ptr<ServiceWorkerHandleReference> controller) override {
DCHECK(registration_);
+ DCHECK(!controller ||
+ controller->handle_id() != kInvalidServiceWorkerHandleId);
controller_ = controller.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698