Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: content/child/service_worker/service_worker_handle_reference.cc

Issue 1478103002: [WIP] [service worker] Fix detach controller and fallback to network mechanism (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: return null in Create/Adopt Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/service_worker/service_worker_handle_reference.h" 5 #include "content/child/service_worker/service_worker_handle_reference.h"
6 6
7 #include "content/child/thread_safe_sender.h" 7 #include "content/child/thread_safe_sender.h"
8 #include "content/common/service_worker/service_worker_messages.h" 8 #include "content/common/service_worker/service_worker_messages.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 scoped_ptr<ServiceWorkerHandleReference> 12 scoped_ptr<ServiceWorkerHandleReference>
13 ServiceWorkerHandleReference::Create( 13 ServiceWorkerHandleReference::Create(
14 const ServiceWorkerObjectInfo& info, 14 const ServiceWorkerObjectInfo& info,
15 ThreadSafeSender* sender) { 15 ThreadSafeSender* sender) {
16 DCHECK(sender); 16 DCHECK(sender);
17 if (info.handle_id == kInvalidServiceWorkerHandleId)
18 return nullptr;
17 return make_scoped_ptr(new ServiceWorkerHandleReference(info, sender, true)); 19 return make_scoped_ptr(new ServiceWorkerHandleReference(info, sender, true));
18 } 20 }
19 21
20 scoped_ptr<ServiceWorkerHandleReference> ServiceWorkerHandleReference::Adopt( 22 scoped_ptr<ServiceWorkerHandleReference> ServiceWorkerHandleReference::Adopt(
21 const ServiceWorkerObjectInfo& info, 23 const ServiceWorkerObjectInfo& info,
22 ThreadSafeSender* sender) { 24 ThreadSafeSender* sender) {
23 DCHECK(sender); 25 DCHECK(sender);
26 if (info.handle_id == kInvalidServiceWorkerHandleId)
27 return nullptr;
24 return make_scoped_ptr(new ServiceWorkerHandleReference(info, sender, false)); 28 return make_scoped_ptr(new ServiceWorkerHandleReference(info, sender, false));
25 } 29 }
26 30
27 ServiceWorkerHandleReference::ServiceWorkerHandleReference( 31 ServiceWorkerHandleReference::ServiceWorkerHandleReference(
28 const ServiceWorkerObjectInfo& info, 32 const ServiceWorkerObjectInfo& info,
29 ThreadSafeSender* sender, 33 ThreadSafeSender* sender,
30 bool increment_ref_in_ctor) 34 bool increment_ref_in_ctor)
31 : info_(info), 35 : info_(info),
32 sender_(sender) { 36 sender_(sender) {
33 if (increment_ref_in_ctor && 37 DCHECK_NE(info.handle_id, kInvalidServiceWorkerHandleId);
34 info_.handle_id != kInvalidServiceWorkerHandleId) { 38 if (increment_ref_in_ctor) {
35 sender_->Send( 39 sender_->Send(
36 new ServiceWorkerHostMsg_IncrementServiceWorkerRefCount( 40 new ServiceWorkerHostMsg_IncrementServiceWorkerRefCount(
37 info_.handle_id)); 41 info_.handle_id));
38 } 42 }
39 } 43 }
40 44
41 ServiceWorkerHandleReference::~ServiceWorkerHandleReference() { 45 ServiceWorkerHandleReference::~ServiceWorkerHandleReference() {
42 if (info_.handle_id != kInvalidServiceWorkerHandleId) { 46 DCHECK_NE(info_.handle_id, kInvalidServiceWorkerHandleId);
43 sender_->Send( 47 sender_->Send(
44 new ServiceWorkerHostMsg_DecrementServiceWorkerRefCount( 48 new ServiceWorkerHostMsg_DecrementServiceWorkerRefCount(info_.handle_id));
45 info_.handle_id));
46 }
47 } 49 }
48 50
49 } // namespace content 51 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698