Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: trunk/src/build/common.gypi

Issue 14781008: Revert 198637 "Use a sysroot for Chrome Linux official builds." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/common.gypi
===================================================================
--- trunk/src/build/common.gypi (revision 198642)
+++ trunk/src/build/common.gypi (working copy)
@@ -61,9 +61,6 @@
# non-Official # builds).
'buildtype%': 'Dev',
- # Override branding to select the desired branding flavor.
- 'branding%': 'Chromium',
-
'conditions': [
# ChromeOS implies ash.
['chromeos==1', {
@@ -104,7 +101,6 @@
'enable_hidpi%': '<(enable_hidpi)',
'enable_touch_ui%': '<(enable_touch_ui)',
'buildtype%': '<(buildtype)',
- 'branding%': '<(branding)',
'host_arch%': '<(host_arch)',
# Default architecture we're building for is the architecture we're
@@ -172,14 +168,6 @@
}, {
'use_default_render_theme%': 0,
}],
-
- # TODO(thestig) Remove the linux_lsb_release check after all the
- # official Ubuntu Lucid builder are gone.
- ['OS=="linux" and branding=="Chrome" and buildtype=="Official" and chromeos==0', {
- 'linux_lsb_release%': '<!(lsb_release -r -s)',
- }, {
- 'linux_lsb_release%': '',
- }], # OS=="linux" and branding=="Chrome" and buildtype=="Official" and chromeos==0
],
},
@@ -203,10 +191,11 @@
'enable_message_center%': '<(enable_message_center)',
'use_default_render_theme%': '<(use_default_render_theme)',
'buildtype%': '<(buildtype)',
- 'branding%': '<(branding)',
'arm_version%': '<(arm_version)',
- 'linux_lsb_release%': '<(linux_lsb_release)',
+ # Override branding to select the desired branding flavor.
+ 'branding%': 'Chromium',
+
# Set to 1 to enable fast builds. Set to 2 for even faster builds
# (it disables debug info for fastest compilation - only for use
# on compile-only bots).
@@ -640,17 +629,6 @@
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/arm-sysroot',
}], # OS=="linux" and target_arch=="arm" and chromeos==0
- ['linux_lsb_release=="12.04"', {
- 'conditions': [
- ['target_arch=="x64"', {
- 'sysroot%': '<!(cd <(DEPTH) && pwd -P)/chrome/installer/linux/internal/debian_wheezy_amd64-sysroot',
- }],
- ['target_arch=="ia32"', {
- 'sysroot%': '<!(cd <(DEPTH) && pwd -P)/chrome/installer/linux/internal/debian_wheezy32-sysroot',
- }],
- ],
- }], # linux_lsb_release=="12.04"
-
['target_arch=="mipsel"', {
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/sysroot',
'CXX%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/bin/mipsel-linux-gnu-gcc',
« no previous file with comments | « trunk/src/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698