ui: Time to empty the ui/test/ directory.

ui: Time to empty the ui/test/ directory.

The remaining pieces in ui/test/ are used only by a unittest in ui/gfx/,
so in this patch we move these files into ui/gfx. This fixes the TODO in
ui/gfx/DEPS that was assigned to Ben.

BUG=None
TEST=ui_unittests
R=tony@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247866

[tfarina, 2014-01-26 00:10:00]

Hi Tony, could you review this to me?

Thanks!

[tony, 2014-01-27 17:47:44]

LGTM.  In the long run, we want to get remove the .rc file and use a .pak file
instead.

[Ben Goodger (Google), 2014-01-27 20:30:34]

lgtm

[tfarina, 2014-01-28 17:14:20]

On 2014/01/27 20:30:34, Ben Goodger (Google) wrote:
> lgtm

Ben, do you know how can I fix the following error (Windows)?

..\..\ui\gfx\icon_util_unittests.rc(33) : error RC2176 : old DIB in
icon_util_unittests.ico; pass it through SDKPAINT

http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/251924...

[commit-bot: I haz the power, 2014-01-28 18:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/147803002/70001

[commit-bot: I haz the power, 2014-01-28 18:55:53]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[tfarina, 2014-01-28 19:12:35]

On 2014/01/28 18:55:53, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

** Presubmit ERRORS **
Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
  ui/gfx/icon_util_unittests.ico

[tfarina, 2014-01-29 00:51:18]

On 2014/01/28 19:12:35, tfarina wrote:
> On 2014/01/28 18:55:53, I haz the power (commit-bot) wrote:
> > Retried try job too often on chromium_presubmit for step(s) presubmit
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> 
> ** Presubmit ERRORS **
> Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
>   ui/gfx/icon_util_unittests.ico

Ben, can you run this command for me? I don't have a Windows svn checkout.

[tfarina, 2014-01-29 12:14:39]

On 2014/01/29 00:51:18, tfarina wrote:
> On 2014/01/28 19:12:35, tfarina wrote:
> > On 2014/01/28 18:55:53, I haz the power (commit-bot) wrote:
> > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > 
> > ** Presubmit ERRORS **
> > Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
> >   ui/gfx/icon_util_unittests.ico
> 
> Ben, can you run this command for me? I don't have a Windows svn checkout.

Hey Tony, would you make a separate CL for me on Windows that copies
ui/test/ui_unittests.ico to ui/gfx/icon_util_unittests.ico and sets the
mime-type?

Otherwise, do you know who I can ask for?

[tony, 2014-01-29 23:21:23]

On 2014/01/29 12:14:39, tfarina wrote:
> On 2014/01/29 00:51:18, tfarina wrote:
> > On 2014/01/28 19:12:35, tfarina wrote:
> > > On 2014/01/28 18:55:53, I haz the power (commit-bot) wrote:
> > > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > > 
> > > ** Presubmit ERRORS **
> > > Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
> > >   ui/gfx/icon_util_unittests.ico
> > 
> > Ben, can you run this command for me? I don't have a Windows svn checkout.
> 
> Hey Tony, would you make a separate CL for me on Windows that copies
> ui/test/ui_unittests.ico to ui/gfx/icon_util_unittests.ico and sets the
> mime-type?
> 
> Otherwise, do you know who I can ask for?

You should be able to do this yourself on a svn checkout on any OS (should work
from Linux).

Also, I think you could also fix the svn prop file:
http://src.chromium.org/svn/trunk/tools/build/slave/config
It doesn't seem to know about ico but if you add the right type there, the
commit
bot might be able to land the patch.  maruel may know.

[tfarina, 2014-01-29 23:48:01]

On 2014/01/29 23:21:23, tony wrote:
> On 2014/01/29 12:14:39, tfarina wrote:
> > On 2014/01/29 00:51:18, tfarina wrote:
> > > On 2014/01/28 19:12:35, tfarina wrote:
> > > > On 2014/01/28 18:55:53, I haz the power (commit-bot) wrote:
> > > > > Retried try job too often on chromium_presubmit for step(s) presubmit
> > > > >
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> > > > 
> > > > ** Presubmit ERRORS **
> > > > Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
> > > >   ui/gfx/icon_util_unittests.ico
> > > 
> > > Ben, can you run this command for me? I don't have a Windows svn checkout.
> > 
> > Hey Tony, would you make a separate CL for me on Windows that copies
> > ui/test/ui_unittests.ico to ui/gfx/icon_util_unittests.ico and sets the
> > mime-type?
> > 
> > Otherwise, do you know who I can ask for?
> 
> You should be able to do this yourself on a svn checkout on any OS (should
work
> from Linux).
>
Did this in https://codereview.chromium.org/143263021/
 
Rebased and pushing to CQ.

[commit-bot: I haz the power, 2014-01-29 23:56:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/147803002/190001

[commit-bot: I haz the power, 2014-01-30 07:14:15]

Change committed as 247866