Remove _Unwind_* stubs from pnacl_abi.bc

pnacl/driver/pnacl-ld.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # IMPORTANT NOTE: If you make local mods to this file, you must run:
 #   %  pnacl/build.sh driver
 # in order for them to take effect in the scons build.  This command
 # updates the copy in the toolchain/ tree.
 #
@@ skipping 82 matching lines @@
   'LIBS_X8664'       : '${BASE_GLIBC}/lib-x86-64',
   'LIBS_MIPS32'      : '${BASE_GLIBC}/lib-mips32',
   # HACK-END
 
   'LD_GOLD_OFORMAT'        : '${LD_GOLD_OFORMAT_%ARCH%}',
   'LD_GOLD_OFORMAT_ARM'    : 'elf32-littlearm',
   'LD_GOLD_OFORMAT_X8632'  : 'elf32-i386-nacl',
   'LD_GOLD_OFORMAT_X8664'  : 'elf64-x86-64-nacl',
   'LD_GOLD_OFORMAT_MIPS32' : 'elf32-tradlittlemips',
 
-  'BCLD'      : '${LD_GOLD}',
-  'BCLD_FLAGS': '--oformat ${LD_GOLD_OFORMAT} -Ttext=0x20000 ' +
-                '${!SHARED && !RELOCATABLE ? --undef-sym-check} ' +
-                '${GOLD_PLUGIN_ARGS} ${LD_FLAGS}',
+  'BCLD'                   : '${LD_GOLD}',
+  'FINAL_BCLD_LINK_FLAGS'  :
+    '--undef-sym-check --allow-unresolved=_Unwind_DeleteException ' +

[jvoung (off chromium), 2013/05/07 18:11:55]

keep one exception per line so that they are easier to see?

Should the list of exceptions only be there when ALLOW_CXX_EXCEPTIONS is true?

[Mark Seaborn, 2013/05/07 18:16:06]

Also, you can omit the "+": Python does C-style string literal concatenation.
Right.  It would be better to get a bitcode-link-time error than an ABI verifier
error if you're using these symbols wrongly.

[eliben, 2013/05/07 18:55:04]

Done.

[eliben, 2013/05/07 18:55:04]

Done, although it was consistent with the surrounding script's style.
 
Done

+    '--allow-unresolved=_Unwind_GetIP --allow-unresolved=_Unwind_GetIPInfo ' +
+    '--allow-unresolved=_Unwind_Resume --allow-unresolved=_Unwind_GetCFA ' +
+    '--allow-unresolved=_Unwind_Backtrace --allow-unresolved=_Unwind_SetIP ' +
+    '--allow-unresolved=_Unwind_GetRegionStart ' +
+    '--allow-unresolved=_Unwind_GetDataRelBase ' +
+    '--allow-unresolved=_Unwind_GetTextRelBase ' +
+    '--allow-unresolved=_Unwind_GetLanguageSpecificData ' +
+    '--allow-unresolved=_Unwind_PNaClSetResult0 ' +
+    '--allow-unresolved=_Unwind_PNaClSetResult1 ' +
+    '--allow-unresolved=_Unwind_RaiseException ' +
+    '--allow-unresolved=_Unwind_Resume_or_Rethrow ',
+
+  'BCLD_FLAGS':
+    '--oformat ${LD_GOLD_OFORMAT} -Ttext=0x20000 ' +
+    '${!SHARED && !RELOCATABLE ? ${FINAL_BCLD_LINK_FLAGS}} ' +
+    '${GOLD_PLUGIN_ARGS} ${LD_FLAGS}',
   'RUN_BCLD': ('${BCLD} ${BCLD_FLAGS} ${inputs} -o ${output}'),
 
   'ALLOW_CXX_EXCEPTIONS': '0',
   'DISABLE_ABI_CHECK': '0',
   'LLVM_PASSES_TO_DISABLE': '',
 }
 
 def AddToBCLinkFlags(*args):
   env.append('LD_FLAGS', *args)
 
@@ skipping 430 matching lines @@
   -O<opt-level>               Optimize output file
   -M, --print-map             Print map file on standard output
   --whole-archive             Include all objects from following archives
   --no-whole-archive          Turn off --whole-archive
   -s, --strip-all             Strip all symbols
   -S, --strip-debug           Strip debugging symbols
   --undefined SYMBOL          Start with undefined reference to SYMBOL
 
   -help | -h                  Output this help.
 """