Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1477983002: XFA: Needless include in fpdfppo.cpp (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Not needed, actually. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M fpdfsdk/src/fpdfppo.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, quick review of "ouch" comment.
5 years ago (2015-11-25 23:02:38 UTC) #2
Tom Sepez
... and TBR since nothing but red and its blocking regenerating diffs.
5 years ago (2015-11-25 23:16:46 UTC) #5
Lei Zhang
I thought you said there were IWYU issues. But if this works, then lgtm.
5 years ago (2015-11-25 23:19:59 UTC) #6
Tom Sepez
5 years ago (2015-11-25 23:21:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
214947de80a9be2ddb134b1962affc82e20563c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698