Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1477963002: dom-if cr-policy-pref-indicator in settings_checkbox/input (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_560432_settings_benchmark_2c_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dom-if cr-policy-pref-indicator in settings_checkbox/input This gives us a straight up 10-20% load time improvement in the accessibility and privacy pages which are mostly checkboxes. BUG=561705 Committed: https://crrev.com/bc19721165fa0ed4b82aedd9754d899badfc91fa Cr-Commit-Position: refs/heads/master@{#362239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +3 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
stevenjb
5 years ago (2015-11-25 21:30:43 UTC) #2
michaelpg
lgtm, but can you create a performance tracking bug for non-page-specific stuff like this?
5 years ago (2015-11-25 21:35:35 UTC) #3
stevenjb
On 2015/11/25 21:35:35, michaelpg wrote: > lgtm, but can you create a performance tracking bug ...
5 years ago (2015-11-25 21:43:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477963002/1
5 years ago (2015-11-25 21:46:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-25 23:51:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477963002/1
5 years ago (2015-11-30 20:25:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 22:15:56 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 22:17:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc19721165fa0ed4b82aedd9754d899badfc91fa
Cr-Commit-Position: refs/heads/master@{#362239}

Powered by Google App Engine
This is Rietveld 408576698