Add rect clip to convex_poly_clip GM

Add rect clip to convex_poly_clip GM

BUG=skia:2051
Committed: http://code.google.com/p/skia/source/detail?r=13300

[robertphillips, 2014-02-03 22:32:45]

lgtm + 1 ignoreable suggestion.

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp
File gm/convexpolyclip.cpp (right):

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp#ne...
gm/convexpolyclip.cpp:239: fRect = rect;
if (kPath_ClipType == fClipType) {
    fPath.reset();
}

moved up to start of method?

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp#ne...
gm/convexpolyclip.cpp:246: ClipType fClipType;
union?

[robertphillips, 2014-02-03 22:40:27]

I retract that suggestion (using a union).

[bsalomon, 2014-02-04 14:24:34]

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp
File gm/convexpolyclip.cpp (right):

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp#ne...
gm/convexpolyclip.cpp:239: fRect = rect;
On 2014/02/03 22:32:45, robertphillips wrote:
> if (kPath_ClipType == fClipType) {
>     fPath.reset();
> }
> 
> moved up to start of method?

The path object is always valid (no union).

https://codereview.chromium.org/147793007/diff/30001/gm/convexpolyclip.cpp#ne...
gm/convexpolyclip.cpp:246: ClipType fClipType;
On 2014/02/03 22:32:45, robertphillips wrote:
> union?

SkPath can't be in a union, it'd have to be SkPath*. I think it'd just add
complexity.

[robertphillips, 2014-02-04 14:29:20]

> SkPath can't be in a union, it'd have to be SkPath*. I think it'd just add
> complexity.

Yep - that's why I retracted my suggestion. I realized that the second I hit the
publish button :(

[bsalomon, 2014-02-04 14:48:34]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-02-04 14:48:41]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/147793007/30001

[commit-bot: I haz the power, 2014-02-04 15:09:18]

Change committed as 13300

[skia-commit-bot, 2014-02-04 15:09:25]

CQ bit was unchecked on CL. Ignoring.